DOC: Add tuple description to allowed inputs for iloc #47799 #47989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pratikpatel2512
commented
Aug 6, 2022
•
pratikpatel2512
commented
- closes DOC: iloc docs should indicate a tuple is valid #47799
- All code checks passed.
phofl
reviewed
Aug 6, 2022
pandas/core/indexing.py
Outdated
| @@ -155,6 +155,8 @@ def iloc(self) -> _iLocIndexer: | |||
| DataFrame) and that returns valid output for indexing (one of the above). | |||
| This is useful in method chains, when you don't have a reference to the | |||
| calling object, but would like to base your selection on some value. | |||
| - A tuple of row and column indexes, e.g. ``0, 1`` or ``[1, 2], [2, 5]`` or | |||
There was a problem hiding this comment.
Maybe add that the tuple elements consist of one of the above mentioned ones instead of given examples
There was a problem hiding this comment.
Also I would add the parentheses to make it explit they are tuples. e,g, ([1,2], [2,5]).
There was a problem hiding this comment.
Acknowledged the comments and updated the statement.
There was a problem hiding this comment.
Are we suppose to run around 30 some checks for document updates?
pratikpatel2512
force-pushed
the
iloc-doc-fix
branch
from
bb78f2c to
f0b3356
Compare
mroeschke
added
Docs
Indexing
mroeschke
approved these changes
Aug 8, 2022
|
Thanks @pratikpatel2512 |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
pandas-dev#47989) DOC: Add tuple description to allowed inputs for iloc
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.